[PATCH] Return error if lockdown fails starting a service
Reported by Martin S. | April 16th, 2009 @ 07:19 PM
The codepath of "iphone_lckd_start_service" currently fails for the case when the requested service could not be started and a "Result:Failure" is returned from the device. It returns the "ret" variable of the last iphone_mux_recv() call which will still be IPHONE_E_SUCCESS.
This also leads to issues with the Python API as the code below would never trigger if the service fails to start:
self._mobile_sync = self._lckd.get_mobile_sync_client()
if not self._mobile_sync:
# never reached
print "Mobilesync session couldn't be established."
sys.exit(-1)
Attached patch fixes this case and also introduces a new error code for this case.
Comments and changes to this ticket
-
Matt Colyer April 19th, 2009 @ 10:23 PM
- State changed from “new” to “resolved”
(from [63e5eed5542c8c85144ee0ac20174c0859fab866]) Make sure start_service returns an error if it fails to start the service
[#34 state:resolved]
Signed-off-by: Matt Colyer matt@colyer.name http://github.com/MattColyer/lib...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
A project around supporting the iPhone in Linux.
See http://libimobiledevice.org
People watching this ticket
Martin S.
Matt Colyer
Attachments
Referenced by
-
34
[PATCH] Return error if lockdown fails starting a service
[#34
state:resolved]