[PATCH] NotificationProxy updated

The implementation for lockdownd_get_device_name seems missing from the patch.

Yes, right. Here is the complete patch.

Well, here is the complete patch.

You have a typo "g_strfr eev(dirs);" should be "g_strfreev(dirs);". Also "iphone_mux_recv_timeout" which you are using seems not to be defined in libiphone master.

I changed it to "iphone_mux_recv" here and got it working, good job!

Would it be possible to implement some kind of notification callback instead of needing to poll for the notification_proxy stuff?

Hi again. This is the new and tested patch. It fixes the errors reported, introduces the iphone_mux_recv_timeout function as well as iphone_np_set_notify_callback which is used in iphoneclient test program. It's running in a new thread that polls for notifications sent by the notification proxy on the device.

Hi, the previous patch causes some problems when running the iphoneclient tool due to the notification callback implementation. My usbmuxd aware implementation is working perfectly with it, but to avoid trouble until the usbmuxd stuff is integrated, apply the attached patch after applying 'notification_proxy_new_update_fixed.diff'. This will just disable the callback usage in iphoneclient and reactivates the standard active check for incoming notifications.

Here's the first patch updated and created with git format-patch.

... and here's the second one.

Should I merge this in now or wait for the usbmux stuff to land?