[PATCH] afc: cleanup and improved error handling
Reported by Nikias Bassen | April 19th, 2009 @ 03:16 PM | in 1.0 Release
Here's a patch that updates the afc implementation to do some better error handling. includes a rewrite of receive_AFC_data, which had some issues (esp. regarding usbmuxd) that are now fixed. besides that it stores an error value which can be read with iphone_afc_get_afcerror or iphone_afc_get_errno which allows e.g. ifuse to retrieve a useful error code. The get_attr function now reads the number of links on a file (st_nlink) and the file types include also symlink files (even if we cannot read the link target, it makes sense to report the files as symlinks). I also removed all compiler warnings except one for AFC.c.
This patch expects the patches from Ticket 4, Ticket 26 and Ticket 27 to be applied before.
This patch includes some changes that Paul gave to me: http://www.paul.sladen.org/proje...
Comments and changes to this ticket
-
Nikias Bassen April 19th, 2009 @ 03:19 PM
- Assigned user set to “Matt Colyer”
Here's an update to ifuse which makes use of the afc error handling. Apply after applying the patch from Ticket 4. Only ifuse_getattr and ifuse_open are modified here, but the other function should be updated aswell. But now I've different work todo ;)
-
Nikias Bassen April 20th, 2009 @ 12:09 AM
- Milestone set to “1.0 Release”
-
-
-
Matt Colyer May 8th, 2009 @ 03:17 PM
- State changed from “new” to “resolved”
(from [d30ef14da1ca630c1842f1d47bd89abdc023585d]) afc error handling in ifuse_open and ifuse_getattr
[#37 state:resolved]
Signed-off-by: Matt Colyer matt@colyer.name http://github.com/MattColyer/ifu...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
A project around supporting the iPhone in Linux.
See http://libimobiledevice.org
Matt Colyer
Nikias Bassen
