[PATCH] support for setting file modification times
-
Martin S.
As usual, awesome stuff!
Some questions though:
- I am not sure if this is rather 1.2.0 material...
- How does this work if ifuse/gvfs-afc attempt to use this on pre 3.1 devices?
-
Matt Colyer
I don't have strong opinions about waiting or not for 1.0 here so I'll defer to what you guys think is best. It would be good to know what happens on devices that don't support these features though.
-
Nikias Bassen
I would say it is a non-API/ABI-breaking extension so it is not critical to include the patches.
Concerning the compatibility with pre-3.1 devices: With the above patches an error is reported, e.g. ifuse reports an IO error.
I reworked the patches so that the AFC_E_UNKNOWN_PACKET_TYPE error reported by pre-3.1 devices is ignored. So that the operation seems to success for those devices.I removed the gvfs and ifuse patches from above. The libiphone patch (the one with 0002) remains valid. Attached is the patch for ifuse, I'll forward the gvfs patch directly to the responsible person.
-
Matt Colyer
- State changed from open to resolved
(from [549f4389e3009d9f78b94d4a3570e29f428968ab]) AFC: new function afc_set_file_time
This function allows to set the modification time of a file. The
time value needs to be specified as nanoseconds since epoch.[#81 [PATCH] support for setting file modification times state:resolved]
Signed-off-by: Matt Colyer matt@colyer.name
http://github.com/MattColyer/libiphone/commit/549f4389e3009d9f78b94...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
