#317 ✓resolved
Bilson Pérez

ideviceinstaller - Error with #ifdef HAVE_LIBIMOBILEDEVICE_1_0

Reported by Bilson Pérez | February 18th, 2013 @ 06:57 PM

I realized these issues when compiling ideviceinstaller. I think they haven't been fixed yet.
In last version (1.0.1) of ideviceinstaller.c (http://cgit.sukimashita.com/ideviceinstaller.git/tree/src/idevicein...), lines 71 to 75 say:

72 static void notifier(const char *notification, void *unused)
73 #else
74 static void notifier(const char *notification)
75 #endif

It should be:

Because in /include/libimobiledevice/notification_proxy.h line 90 it expects a pointer to function with 2 parameters:
90 typedef void (*np_notify_cb_t) (const char *notification, void *user_data);

The same occurs in ideviceinstaller.c line 422:
423 np_set_notify_callback(np, notifier, NULL);
424 #else
425 np_set_notify_callback(np, notifier);
426 #endif

It should be:
because as we can see in /include/libimobiledevice/notification_proxy.h line 98, it expects 3 parameters instead of 2:
98: np_error_t np_set_notify_callback(np_client_t client, np_notify_cb_t notify_cb, void *userdata);

(sorry if my English is not very good).

Comments and changes to this ticket

  • Martin S.

    Martin S. March 18th, 2013 @ 04:56 PM

    • State changed from “new” to “resolved”
    • Tag set to ideviceinstaller
    • Assigned user set to “Martin S.”

    Thanks for reporting. Fixed in git master.
    This has not been noticed as HAVE_LIBIMOBILEDEVICE_1_0 is always defined if HAVE_LIBIMOBILEDEVICE_1_1 is.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

A project around supporting the iPhone in Linux.

See http://libimobiledevice.org

People watching this ticket