When compiling sbmanager I stumbled across the following
error:
$ make make all-recursive
make[1]: Entering directory
/var/local/downloads/iphone/sbmanager'<br/> Making all
in data<br/> make[2]: Entering
directory/var/local/downloads/iphone/sbmanager/data'
make[2]: Nothing to be done for all'.<br/> make[2]:
Leaving
directory/var/local/downloads/iphone/sbmanager/data'
Making all in src
make[2]: Entering directory
/var/local/downloads/iphone/sbmanager/src'<br/> CC
libsbmanager_la-device.lo cc1: warnings being treated as
errors<br/> device.c: In function
'device_sbs_save_icon':<br/> device.c:138: error: ignoring
return value of 'fwrite', declared with attribute
warn_unused_result<br/> make[2]: ***
[libsbmanager_la-device.lo] Error 1<br/> make[2]: Leaving
directory/var/local/downloads/iphone/sbmanager/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
/var/local/downloads/iphone/sbmanager'<br/> make: ***
[all] Error 2
Here is a small patch for this problem
(see also the attached file
sbmanager_check_return_fwrite.patch)
--- src/device.c 2010/06/24 00:35:37 1.1 +++ src/device.c
2010/06/24 00:53:10 1.7 @@ -135,7 +135,9 @@
if ((sbservices_get_icon_pngdata(sbc, display_identifier, &png, &pngsize) == SBSERVICES_E_SUCCESS) && (pngsize > 0)) {
/* save png icon to disk */
FILE *f = fopen(filename, "w");
-
fwrite(png, 1, pngsize, f);
-
if (fwrite(png, 1, pngsize, f) != sizeof(pngsize)){
-
*error = g_error_new(device_domain, EIO, _("Could not save icon png to disk!"));
-
}
fclose(f);
res = TRUE;
} else {